Version #528
Merged
Version #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #483, that unfortunately was closed, but both commits were still available;
this PR starts with these commits (thanks @GeraldJansen !),
centralize the version in
hamster.__version__This takes less than 8 ms, negligible compared to the python script launch itself (150 ms).
The effort necessary to evaluate that only when needed would be disproportionate.
(except creating a
version()function, but that would be lessBy the way, the "running installed" test is now centralized.
bump2version is used to set the default values,
and update the NEWS headers as well.
The D-Bus service has now a
Version()method.Added a warning for client/server version mismatch (#526 and others).