Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'headless' option to run.py to allow wolf_sheep to run headless #29

Merged

Conversation

smubita
Copy link

@smubita smubita commented Apr 25, 2023

An example of how to modify an existing example (wolf_sheep) to include an optional headless option. This is related to the discussion topic here: projectmesa/mesa#1645

@jackiekazil
Copy link
Member

@smubita - we added the pre-commit.ci to fix the build issue. Can you update your branch from main, then re-push. The build should be fixed after that.

Stephen Mubita added 2 commits April 25, 2023 14:44
@smubita
Copy link
Author

smubita commented Apr 25, 2023

Hi, @jackiekazil . I pulled from main the original repo. I also made changes according to the maintainer's remarks in the issue I opened, and copied the change to most of the examples in the repo.

@jackiekazil
Copy link
Member

I am okay with this, but this to me is a more impactful change & @rht has commented on other threads related to this, so I want to let him chim in before merging.

@jackiekazil jackiekazil requested a review from rht April 25, 2023 23:33
@rht
Copy link
Contributor

rht commented Apr 25, 2023

I agree with the changes. :)

@jackiekazil
Copy link
Member

LGTM! Thank you for the contribution!

@jackiekazil jackiekazil merged commit 16bfd95 into projectmesa:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants