-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JupyterViz grid display should be optional, since not all models use a grid or agent space #1778
Comments
I can see your point, where some models don't have an explicit grid/space, but my concern is that some users might blunder by forgetting to create a space, and the explicit error/breakage helps to remind them. The other option is to have a flag that lets user explicitly disable drawing space. |
@rht that sounds fine to me; seems good to require users to explicitly opt out of displaying the space. Could you suggest a simple way to implement this? What about defining an argument for the |
Fixed in #1783. |
What's the problem this feature will solve?
currently JupyterViz breaks if
model.grid
is not definedDescribe the solution you'd like
model.grid
should continue to be optional; space should only be drawn when the model has a grid.From testing locally, it looks like it is sufficient to modify the
make_space
method to check for thegrid
attribute and do nothing when it is defined. I'm willing to open a PR with this change if this solution is sufficient.Additional context
Some discussion on #1772
The text was updated successfully, but these errors were encountered: