Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default batch_run to 1 CPU #1300

Merged
merged 2 commits into from
May 1, 2022
Merged

Default batch_run to 1 CPU #1300

merged 2 commits into from
May 1, 2022

Conversation

rht
Copy link
Contributor

@rht rht commented May 1, 2022

This fixes #1210.
This is a BREAKING CHANGE.
This simplifies the introductory tutorial.

I didn't implement the warning on Windows when using multiprocessing, because I want to keep this PR small, and I think Python already does the warning by default?

@rht rht force-pushed the batch_run_1cpu branch from f305768 to dfbc421 Compare May 1, 2022 02:44
@rht rht force-pushed the batch_run_1cpu branch from dfbc421 to 03bdc65 Compare May 1, 2022 02:53
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #1300 (03bdc65) into main (def2c1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1300   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files          19       19           
  Lines        1245     1245           
  Branches      246      246           
=======================================
  Hits         1109     1109           
  Misses        101      101           
  Partials       35       35           
Impacted Files Coverage Δ
mesa/batchrunner.py 93.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def2c1b...03bdc65. Read the comment docs.

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool you did a snippet... LGTM

@tpike3 tpike3 merged commit 604bd0f into projectmesa:main May 1, 2022
@rht rht deleted the batch_run_1cpu branch May 1, 2022 11:20
@jackiekazil jackiekazil added this to the Quartzsite (next release) milestone Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch_run should default to running on 1 CPU
3 participants