-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Conway example #2403
Update Conway example #2403
Conversation
for more information, see https://pre-commit.ci
Performance benchmarks:
|
Thanks! Could you maybe add screenshots how it looked before and after? |
There is no before because there was no solara version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sliders to change the grid size and initial fraction alive would be nice. You can steal them from: mesa-examples/examples/conways_game_of_life_fast/app.py
Disabling the gridlines and making the agents square would be really improve the viz, see how it looks with the PropertyLayer visualisation. But that can be another PR.
Otherwise, looking good, so going to pre-approve. A screenshot of the final viz in the PR description would be appreciated.
I agree, but changing the marker requires changes in matplotlib.py. Enabling/disabling gridlines is something that probably should become controllabe at the level of |
This adds a solara-based
app.py
, renames the oldapp.py
tost_app.py
for streamlit, updatesreadme.md
with correct run instructions, and some minor cleanup and removal of oudated files.