Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Conway example #2403

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Update Conway example #2403

merged 4 commits into from
Oct 24, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 23, 2024

This adds a solara-based app.py, renames the old app.py to st_app.py for streamlit, updates readme.md with correct run instructions, and some minor cleanup and removal of oudated files.

@quaquel quaquel requested review from tpike3 and jackiekazil October 23, 2024 18:35
@quaquel quaquel added the docs Release notes label label Oct 23, 2024
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 -0.1% [-0.4%, +0.2%] 🔵 +0.3% [+0.2%, +0.5%]
BoltzmannWealth large 🔵 -0.2% [-0.5%, +0.1%] 🔵 +0.5% [+0.2%, +0.9%]
Schelling small 🔵 -0.1% [-0.6%, +0.4%] 🔵 -0.4% [-0.8%, -0.1%]
Schelling large 🔵 +0.6% [-0.3%, +1.4%] 🔵 -0.8% [-1.7%, -0.1%]
WolfSheep small 🔵 +0.5% [+0.4%, +0.7%] 🔵 +1.1% [+0.9%, +1.3%]
WolfSheep large 🔵 +1.1% [+0.8%, +1.4%] 🔵 +1.3% [+0.8%, +1.8%]
BoidFlockers small 🔵 +0.4% [-0.4%, +1.1%] 🔵 +0.7% [-0.2%, +1.6%]
BoidFlockers large 🔵 +0.4% [-0.7%, +2.0%] 🔵 -0.5% [-1.1%, +0.2%]

@EwoutH
Copy link
Member

EwoutH commented Oct 24, 2024

Thanks! Could you maybe add screenshots how it looked before and after?

@quaquel
Copy link
Member Author

quaquel commented Oct 24, 2024

There is no before because there was no solara version.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sliders to change the grid size and initial fraction alive would be nice. You can steal them from: mesa-examples/examples/conways_game_of_life_fast/app.py

Disabling the gridlines and making the agents square would be really improve the viz, see how it looks with the PropertyLayer visualisation. But that can be another PR.

Otherwise, looking good, so going to pre-approve. A screenshot of the final viz in the PR description would be appreciated.

@quaquel
Copy link
Member Author

quaquel commented Oct 24, 2024

Disabling the gridlines and making the agents square would be really improve the viz, see how it looks with the PropertyLayer visualisation. But that can be another PR.

I agree, but changing the marker requires changes in matplotlib.py. Enabling/disabling gridlines is something that probably should become controllabe at the level of make_space_matplotlib.

@quaquel quaquel merged commit 3e2de47 into projectmesa:main Oct 24, 2024
11 of 13 checks passed
@quaquel quaquel deleted the conway_solara branch October 25, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants