Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change invalid token test to expired #1933

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

dimas-b
Copy link
Member

@dimas-b dimas-b commented Sep 9, 2021

It does not currently seem possible to properly configure
WireMock stubs for the completely bogus auth token to
avoid "unstubbed" request error log messages in runtime.

So, for now let's use an expired token to validate the
handling of "unauthenticated" requests.


This change is Reviewable

It does not currently seem possible to properly configure
WireMock stubs for the completely bogus auth token to
avoid "unstubbed" request error log messages in runtime.

So, for now let's use an expired token to validate the
handling of "unauthenticated" requests.
@dimas-b dimas-b requested a review from rymurr September 9, 2021 15:39
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1933 (eb7cba5) into main (9e5fd2b) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1933      +/-   ##
============================================
+ Coverage     81.87%   82.02%   +0.15%     
  Complexity     2970     2970              
============================================
  Files           371      366       -5     
  Lines         16569    16543      -26     
  Branches       1223     1211      -12     
============================================
+ Hits          13566    13570       +4     
+ Misses         2452     2422      -30     
  Partials        551      551              
Flag Coverage Δ
java 82.68% <ø> (ø)
javascript 3.29% <ø> (+2.33%) ⬆️
python 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ui/src/App.tsx 0.00% <0.00%> (ø)
ui/src/setupProxy.ts 0.00% <0.00%> (ø)
ui/src/serviceWorker.ts 0.00% <0.00%> (ø)
ui/src/Explore/Explore.tsx 0.00% <0.00%> (ø)
ui/src/Explore/TableHead.tsx 0.00% <0.00%> (ø)
ui/src/utils/api-wrapper.tsx 0.00% <0.00%> (ø)
ui/src/Explore/ExploreLink.tsx 0.00% <0.00%> (ø)
ui/src/Explore/TableListing.tsx 0.00% <0.00%> (ø)
ui/src/build-scripts/fix-generated-client.js 0.00% <0.00%> (ø)
ui/src/utils/handle-response.tsx
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5fd2b...eb7cba5. Read the comment docs.

@dimas-b
Copy link
Member Author

dimas-b commented Sep 9, 2021

Related Quarkus PR: quarkusio/quarkus#20035

@dimas-b dimas-b merged commit 079faab into projectnessie:main Sep 9, 2021
@dimas-b dimas-b deleted the fix-wiremock-stubs branch September 9, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants