Add specific error code to REST API #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
added
java
Codecov Report
@@ Coverage Diff @@
## main #2443 +/- ##
============================================
+ Coverage 83.96% 84.19% +0.23%
- Complexity 1903 1916 +13
============================================
Files 246 251 +5
Lines 10714 10769 +55
Branches 769 764 -5
============================================
+ Hits 8996 9067 +71
+ Misses 1405 1397 -8
+ Partials 313 305 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
omarsmak
reviewed
Oct 21, 2021
clients/client/src/main/java/org/projectnessie/client/rest/ResponseCheckFilter.java
Show resolved
Hide resolved
snazy
reviewed
Oct 21, 2021
model/src/main/java/org/projectnessie/error/NessieNotFoundException.java
Outdated
Show resolved
Hide resolved
model/src/main/java/org/projectnessie/error/NessieNotFoundException.java
Outdated
Show resolved
Hide resolved
model/src/main/java/org/projectnessie/error/NessieReferenceConflictException.java
Outdated
Show resolved
Hide resolved
servers/services/src/main/java/org/projectnessie/services/impl/ContentsApiImpl.java
Outdated
Show resolved
Hide resolved
model/src/main/java/org/projectnessie/error/NessieContentsNotFoundException.java
Outdated
Show resolved
Hide resolved
servers/jax-rs-tests/src/main/java/org/projectnessie/jaxrs/AbstractTestRest.java
Show resolved
Hide resolved
model/src/main/java/org/projectnessie/error/NessieIllegalArgumentException.java
Outdated
Show resolved
Hide resolved
|
@snazy : do we want this in |
* Add `errorCode` to the `NessieError` object, whose JSON representation is set to clients as HTTP error response payload. This is necessary to allow clients to distinguish Nessie-specific failure mode that fall under the same HTTP status code. * Note: this will break Nessie error response handling in older java clients. * Add more specific exception classes to `nessie-model` * Update java client to unwrap and throw (more) specific exceptions based on `NessieError` payload error codes. * Corresponding Python client changes to follow in a separate commit. * Fix a `TreeApiImpl.meta()` to throw a NessieIllegalArgumentException instead of NessieConflictException when the committer is set by the user. * Refactor `toHash()` in `TreeApiImpl` to remove unnecessary `Optional` * Minor code cleanup in `AbstractTestRest` Closes projectnessie#477
dimas-b
force-pushed
the
api-exception-classes
branch
from
8585680 to
521e53e
Compare
snazy
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
errorCodeto theNessieErrorobject, whose JSON representationis set to clients as HTTP error response payload. This is necessary to
allow clients to distinguish Nessie-specific failure mode that fall
under the same HTTP status code.
Note: this will break Nessie error response handling in older java clients.
Add more specific exception classes to
nessie-modelUpdate java client to unwrap and throw (more) specific exceptions based
on
NessieErrorpayload error codes.Corresponding Python client changes to follow in a separate commit.
Fix a
TreeApiImpl.meta()to throw a NessieIllegalArgumentExceptioninstead of NessieConflictException when the committer is set by the user.
Refactor
toHash()inTreeApiImplto remove unnecessaryOptionalMinor code cleanup in
AbstractTestRestCloses #477
Non-trivial changes are in
ErrorCode,NessieError,ResponseCheckFilter,TreeApiImpl(and other ApiImpl classes). The rest of changes is just the ripple effect of the former.