Drop support for Java 8 #9253
Merged
Drop support for Java 8 #9253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
drop-java-8
branch
5 times, most recently
from
19b6280 to
64b0d9e
Compare
adutra
previously approved these changes
Aug 2, 2024
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 10, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
This was referenced Aug 10, 2024
Draft
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 10, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 10, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 10, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 10, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 10, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 11, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 14, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 16, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 17, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 17, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 20, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 20, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
* Remove usage of no longer needed "annotation stripper" plugin * Remove no longer needed `:nessie-model-quarkus` project * Let all "server side" projects use `nessie-conventions-server`, even if this is currently the same as `nessie-conventions-client` * Let all "client side" projects use `nessie-conventions-client`
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 21, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 21, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
XN137
approved these changes
Aug 21, 2024
| @@ -17,7 +17,7 @@ | |||
| import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar | |||
|
|
|||
| plugins { | |||
| id("nessie-conventions-client") | |||
| id("nessie-conventions-server") | |||
There was a problem hiding this comment.
the change looks a bit odd as in other places we change from nessie-conventions-server to nessie-conventions-client 🤔
are we saying both client and server components for iceberg now require j11 ?
or does this fix a previous misconfiguration of using client for a server component?
There was a problem hiding this comment.
Iceberg requires Java >=11 now
There was a problem hiding this comment.
yes but that explains why the convention themselves would change, not why iceberg-bench would switch from client to server
| @@ -18,7 +18,7 @@ import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar | |||
|
|
|||
| plugins { | |||
| alias(libs.plugins.nessie.run) | |||
| id("nessie-conventions-server") | |||
| id("nessie-conventions-client") | |||
There was a problem hiding this comment.
here we switch conventions the other way around.
as both are basically the same convention now, it may not matter but it looks confusing in the diff.
yes
no - jakarta/javax didn't change in this PR |
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 21, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Aug 27, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 6, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
snazy
added a commit
to snazy/nessie
that referenced
this pull request
Sep 10, 2024
Follow up of projectnessie#9253, migrate all annotations to jakarta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.