Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed "Type 'PointModel[]' is not assignable to type 'ConcatArray<BaseModel<any, T>>'" error #356

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Fixed "Type 'PointModel[]' is not assignable to type 'ConcatArray<BaseModel<any, T>>'" error #356

merged 3 commits into from
Jul 22, 2019

Conversation

frank-martinez-27
Copy link
Contributor

@frank-martinez-27 frank-martinez-27 commented Jun 28, 2019 •
edited
Loading

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer because you are awesome

What?

Fixed this error
image

Why?

Couldn't run storybook on my local

How?

Added PointModel type to getSelectedEntities method

Feel-Good "programming lol" image:

(Add your own one below :])

LOL

@lopesc
Copy link

lopesc commented Jul 15, 2019

👍 @dylanvorster FYI

@dylanvorster dylanvorster merged commit ba1401a into projectstorm:master Jul 22, 2019
@lopesc
Copy link

lopesc commented Jul 23, 2019

@dylanvorster Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanvorster dylanvorster dylanvorster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frank-martinez-27 @lopesc @dylanvorster