(feat) introduce maxConsecutiveFailures knob #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianlucam76
force-pushed
the
max-retries
branch
6 times, most recently
from
66f85ed to
abb5705
Compare
The maxConsecutiveFailures option allows control over deployment retry behavior. This optional field defines a threshold for consecutive deployment failures. After the specified number of consecutive failures, Sveltos will stop retrying the deployment. Retries will only resume if the profile configuration is updated. If maxConsecutiveFailures is not configured, Sveltos will retry indefinitely This PR also solves two errors seen few times. The first error as Helm stuck with: "cannot re-use a name that is still in use" This condition should never occur. A previous check ensures that only one ClusterProfile/Profile can manage a Helm Chart with a given name in a specific namespace within a managed cluster. So after an install such error is seen, Sveltos switches to an upgrade. The second error as Helm stck with: "another operation (install/upgrade/rollback) is in progress" As described above this condition should never happen. Sveltos tries to recover by doing first an uninstall and then install back. While this is not ideal, there is no other way to recover from this condition without manual intervention.
gianlucam76
force-pushed
the
max-retries
branch
from
abb5705 to
30d6a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maxConsecutiveFailures option allows control over deployment retry behavior. This optional field defines a threshold for consecutive deployment failures. After the specified number of consecutive failures, Sveltos will stop retrying the deployment.
Retries will only resume if the profile configuration is updated.
If maxConsecutiveFailures is not configured, Sveltos will retry indefinitely
This PR also solves two errors seen few times.
The first error as Helm stuck with: "cannot re-use a name that is still in use"
This condition should never occur. A previous check ensures that only one
ClusterProfile/Profile can manage a Helm Chart with a given name in a
specific namespace within a managed cluster. So after an install such error
is seen, Sveltos switches to an upgrade.
The second error as Helm stck with: "another operation (install/upgrade/rollback) is in progress"
As described above this condition should never happen. Sveltos tries to recover
by doing first an uninstall and then install back. While this is not ideal, there is no
other way to recover from this condition without manual intervention.