-
Notifications
You must be signed in to change notification settings - Fork 378
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: allow prettier configuration in yaml (#2388)
Prettier doesn't support comments in it's json configuration file and emits a warning on unknown field (i.e. `//`) key in config, so the only option to have a marker in the generated config is to either use json5 or yaml for the config. This PR proposes to follow [ESlint component design](https://github.com/projen/projen/blob/main/src/javascript/eslint.ts#L85) and adds `yaml` option to the `prettierSettings` that will output Prettier config in YAML format with appropriate generation marker. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
- Loading branch information
1 parent
8fb67e7
commit 8cba761
Showing
3 changed files
with
37 additions
and
4 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters