Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Delete statefulset Grafana dashboard #1892

Merged
merged 5 commits into from
Apr 27, 2022

Conversation

tamalsaha
Copy link
Contributor

@tamalsaha tamalsaha commented Mar 20, 2022

Signed-off-by: Tamal Saha [email protected]

What this PR does / why we need it:

This was removed from the mixin project. But it was not removed from the chart.
kubernetes-monitoring/kubernetes-mixin#598

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@tamalsaha tamalsaha changed the title Delete statefulset.yaml [kube-prometheus-stack] Delete statefulset Grafana dashboard Mar 20, 2022
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update chart version

@tamalsaha
Copy link
Contributor Author

done!

@monotek
Copy link
Member

monotek commented Mar 21, 2022

@tamalsaha
Copy link
Contributor Author

Yes. I deleted the templates in this folder and then generated using that script.

monotek
monotek previously approved these changes Mar 21, 2022
@stale
Copy link

stale bot commented Apr 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Signed-off-by: Tamal Saha <[email protected]>
@tamalsaha
Copy link
Contributor Author

ping!

monotek
monotek previously approved these changes Apr 23, 2022
charts/kube-prometheus-stack/Chart.yaml Outdated Show resolved Hide resolved
charts/kube-prometheus-stack/Chart.yaml Outdated Show resolved Hide resolved
@tamalsaha
Copy link
Contributor Author

Done!

@monotek monotek merged commit d662610 into prometheus-community:main Apr 27, 2022
@tamalsaha tamalsaha deleted the patch-1 branch April 27, 2022 17:35
@tamalsaha
Copy link
Contributor Author

Thanks!

artificial-aidan pushed a commit to artificialinc/prometheus-community-helm-charts that referenced this pull request Jun 10, 2022
…eus-community#1892)

* Delete statefulset.yaml

Signed-off-by: Tamal Saha <[email protected]>

* Update charts/kube-prometheus-stack/Chart.yaml

Signed-off-by: Tamal Saha <[email protected]>

Co-authored-by: André Bauer <[email protected]>

* Update charts/kube-prometheus-stack/Chart.yaml

Signed-off-by: Tamal Saha <[email protected]>

Co-authored-by: André Bauer <[email protected]>

Co-authored-by: André Bauer <[email protected]>
Signed-off-by: Aidan Jensen <[email protected]>
aiyengar2 pushed a commit to aiyengar2/charts that referenced this pull request Oct 14, 2022
This dashboard was removed from upstream in prometheus-community/helm-charts#1892 so it should be removed from our chart as well since it is no longer supported.
aiyengar2 pushed a commit to aiyengar2/charts that referenced this pull request Oct 14, 2022
This dashboard was removed from upstream in prometheus-community/helm-charts#1892 so it should be removed from our chart as well since it is no longer supported.
aiyengar2 pushed a commit to aiyengar2/charts that referenced this pull request Oct 25, 2022
This dashboard was removed from upstream in prometheus-community/helm-charts#1892 so it should be removed from our chart as well since it is no longer supported.
stamzid pushed a commit to Unstructured-IO/prometheus-community-helm-charts that referenced this pull request Mar 3, 2023
…eus-community#1892)

* Delete statefulset.yaml

Signed-off-by: Tamal Saha <[email protected]>

* Update charts/kube-prometheus-stack/Chart.yaml

Signed-off-by: Tamal Saha <[email protected]>

Co-authored-by: André Bauer <[email protected]>

* Update charts/kube-prometheus-stack/Chart.yaml

Signed-off-by: Tamal Saha <[email protected]>

Co-authored-by: André Bauer <[email protected]>

Co-authored-by: André Bauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants