[prometheus-windows-exporter] Add chart #3476
Conversation
jkroepke
force-pushed
the
windows_exporter
branch
2 times, most recently
from
2fb0462 to
725927e
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
force-pushed
the
windows_exporter
branch
from
725927e to
8b8c397
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
|
In theory, yet. We need a Linux node for the control plane (because there are not windows container for the Kubernetes control plane) and a windows nodes for the binary itself. It can be archived through WSL.... I guess the complexity of such an test environment are high that no one could maintain this here. tbh, we can not test this in GH Actions. |
|
@monotek But we are still testing, if the manifests are valid and does not contain any error. However the DaemonSet will have replica 0 on the GH action pipelines. Theoretically, it chart itself is tested. |
|
do you've used the chart somewhere else yet? |
|
I'm plan to use the helm chart in one of our managed service project. @lippertmarkus if you have the time, maybe you can also this chart on your infrastructure? |
|
@monotek how to move forward here? |
|
I don't have any windows nodes. |
|
Since I'm maintainer of this Chart, I'm at least handle follow-up issues for this helm chart. What about merging this chart for now and handle future bugs separately? |
|
So you have testet the chart now on your windows nodes? |
|
@monotek Yes. The screenshot form first post document that it works. I setup an AKS cluster in azure with windows nodes on a personal subscription from my company. With AKS, it's a no brainer to setup windows nodes. |
* [prometheus-windows-exporter] Add chart Signed-off-by: Jan-Otto Kröpke <[email protected]> * [prometheus-windows-exporter] Apply suggestions Signed-off-by: Jan-Otto Kröpke <[email protected]> --------- Signed-off-by: Jan-Otto Kröpke <[email protected]> Co-authored-by: MH <[email protected]>
What this PR does / why we need it
Add helm chart for windows export.
Tested on a AKS with WS 2022 nodes.
Based on https://github.com/prometheus-community/windows_exporter/blob/master/kubernetes/kubernetes.md
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])