Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle pg_replication_slots on pg<13 #1098

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

michael-todorovic
Copy link
Contributor

This PR fixes #1097 to handle pg < 13 for pg_replication_slots.
The original feat was #1027

Signed-off-by: Michael Todorovic <[email protected]>
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a more descriptive name for the query and I don't know that I love the way the scan uses a slice of any from a maintainability standpoint, but I think the code works as implemented and this can always be cleaned up later.

Thanks!

@sysadmind sysadmind merged commit 9e42fc0 into prometheus-community:master Feb 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

safe_wal_size not available on pg12
2 participants