Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build #764

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Update build #764

merged 1 commit into from
Mar 5, 2023

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Mar 5, 2023

  • Update Go to 1.20.
  • Update golanci-lint.
  • Bump modules.
  • Update CI orb.

@SuperQ SuperQ requested a review from sysadmind March 5, 2023 20:41
sysadmind
sysadmind reviewed Mar 5, 2023
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we may need to fix the lint issue here too.

@SuperQ SuperQ force-pushed the superq/update_build branch from 2cf29ce to d7fc260 Compare March 5, 2023 20:53
@SuperQ
Copy link
Contributor Author

SuperQ commented Mar 5, 2023

Ok, fixed the linting issues.

@SuperQ SuperQ requested a review from sysadmind March 5, 2023 20:56
@SuperQ
Update build
0e654d8 
* Update Go to 1.20.
* Update golanci-lint.
* Bump modules.
* Update CI orb.
* Fix up use of deprecated ioutil.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/update_build branch from d7fc260 to 0e654d8 Compare March 5, 2023 21:20
sysadmind
sysadmind approved these changes Mar 5, 2023
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysadmind sysadmind merged commit d273f97 into master Mar 5, 2023
@sysadmind sysadmind deleted the superq/update_build branch March 5, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysadmind sysadmind sysadmind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperQ @sysadmind @macmiranda