-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Textfile collector: collect files from multiple paths #1262
Textfile collector: collect files from multiple paths #1262
Conversation
bbd1bb7
to
e441743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this!
Is the plan to eventually deprecate the collector.textfile.directory
flag in favour of the collector.textfile.directories
flag? If so, it'd be worth adding a deprecation warning to the old flag (see the process collector for an example).
I wasn't quite sure about deprecating the I think the best way to go is as mentioned from @breed808 - adding a deprecation warning to |
I agree, as long as the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I have one minor concern for the deprecated flag, but everything else is fine.
Thanks for updating this.
EDIT: It'd also be worth rebasing the feature branch on master
to remove the merge commits.
…le path Signed-off-by: Dinifarb <[email protected]>
Signed-off-by: Dinifarb <[email protected]>
Signed-off-by: Dinifarb <[email protected]>
Signed-off-by: Dinifarb <[email protected]>
Signed-off-by: Dinifarb <[email protected]>
Signed-off-by: Dinifarb <[email protected]>
63eea9e
to
7530e7b
Compare
I think this is ready to merge or does it need some further checks/reviews ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for your efforts with this one.
…ollector Textfile collector: collect files from multiple paths
Regarding #1236 and more
Added Features:
collector.textfile.directories
About the
collector.textfile.directories
commmand:For now it is possible to use
collector.textfile.directories
,collector.textfile.directory
or both. They have the same functionality and in case both commands would be used, the dirs are concatenated. I am not sure if that is ok so lets discuss 😉As soon all is settled, I'll update the docs -
collector.textfile.md
😊