Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Refactor service collector metrics #1334

Closed

Conversation

breed808
Copy link
Contributor

  • Removal of state label for windows_service_state metric.

  • Addition of display_name label for windows_service_state metric.

  • Removal of start_mode label for windows_service_start_mode metric.

  • Addition of display_name label for windows_service_start_mode metric.

  • Removal of the windows_service_status metric.

  • Addition of start_mode and current_state labels for the windows_service_info metric.

The above changes have resulted in a ~88% decrease in metrics (6557 -> 761 in a Windows 11 VM).

For more context see #938.

* Removal of `state` label for `windows_service_state` metric.

* Addition of `display_name` label for `windows_service_state` metric.

* Removal of `start_mode` label for `windows_service_start_mode` metric.

* Addition of `display_name` label for `windows_service_start_mode` metric.

* Removal of the `windows_service_status` metric.

* Addition of `start_mode` and `current_state` labels for the
  `windows_service_info` metric.

The above changes have resulted in a ~88% decrease in metrics (6557 ->
761 in a Windows 11 VM).

For more context see prometheus-community#938.

Signed-off-by: Ben Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant