-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cs: Deprecate collector + os: Deprecate metrics [memory metrics moved to memory
collector] (click PR for more information)
#1596
Conversation
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
memory
collector] (click PR for more information)
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
This action has a significant impact |
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jacbo0112 I'm aware of this. And I this PR does not remove any metrics. The old metrics remains. It's not an breaking change. I do breaking change on other, less important collectors. But for the core metrics, I will keep some grace period. Only the documentation for the old metrics will be disappear and mark a deprecated. The plan is to remove them mid-2025. But before this exporter hits 1.0, some actions are mandatory. There is an cs collector which expose cpu and memory metrics. there is an os collector which expose memory metrics. And there is an memory metrics which exposes metrics. It's chaos. |
Signed-off-by: Jan-Otto Kröpke <[email protected]>
memory
collector] (click PR for more information)memory
collector] (click PR for more information)
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
There are no issues with the corresponding product design. It is important to carefully consider changes in indicator names and confirm them all at once after careful consideration to avoid repeated name changes in the future |
My understanding of the windows_time collector is that it is used to obtain Windows time service metrics. But window_os_time checks the Windows time. Windows_os_timezone is used to view the time zone of Windows. Will migrating these two metrics to the Windows time collector result in only requiring the operating system's time and time zone, and requiring a separate collector to be enabled |
Thats fully correct. Any time related metric is now inside time collector. The scope is increased. If you care about time on your system, you might be interest into time service metrics as well. If you need the timezone metric, you habe to enable time collector. Thats the design choice. Splitt large generic collector. Another example is the process_count: It information was collected (but not exposed) in the system collector as well, while the thread count metrics remains on system collector. The paging information inside the os collector will be moved to an separated paging collector as well. |
Please update the table above |
Fixes #1593
cs collector metrics
The metrics still exists, but moved to other collectors,
windows_cs_hostname
windows_os_hostname
windows_cs_physical_memory_bytes
windows_memory_physical_total_bytes
windows_cs_logical_processors
windows_cpu_logical_processor
os collector metrics
windows_os_time
windows_time_current_timestamp_seconds
windows_os_timezone
windows_time_timezone
windows_os_users
count(windows_logon_logon_type)
windows_os_physical_memory_free_bytes
windows_memory_physical_free_bytes
windows_os_process_memory_limit_bytes
windows_memory_process_memory_limit_bytes
windows_os_virtual_memory_free_bytes
windows_memory_commit_limit - windows_memory_committed_bytes
windows_os_visible_memory_bytes
windows_memory_physical_total_bytes
windows_os_virtual_memory_bytes
windows_memory_commit_limit
windows_os_processes_limit
windows_system_process_limit
windows_os_processes
windows_system_processes