-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tcp: use GetExtendedTcpTable to display states Closed, Listening, SynSent, SynRcvd, CloseWait, TimeWait ... #1638
Conversation
fc70d17
to
35f4322
Compare
Hi @astigmata great PR so far! I liked that WMI is not used. But it needs to be restructured a little bit. Do you have an example output of the metrics? In another PR (#1635), I'm also start to use Since the multiple collection may use btw. in 99% of all cases, |
c09e3e1
to
85c6ff2
Compare
@astigmata After a review, I can take the lint issues, thats fine! |
…irewallException` (prometheus-community#1611) Signed-off-by: astigmata <[email protected]>
…rometheus-community#1603) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: astigmata <[email protected]>
…rometheus-community#1561) Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
…ity#1625) Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
…y default) (prometheus-community#1627) Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
…ty#1631) Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: astigmata <[email protected]>
…information) (prometheus-community#1633) Signed-off-by: astigmata <[email protected]>
…s-community#1634) Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: astigmata <[email protected]>
Signed-off-by: astigmata <[email protected]>
8041127
to
e94ec65
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke Thank you for the help, it's my first contrib |
Oh, you did it very well for the first contribution! :-) I will leave it open for now, because I would like to deliver some bug-fix only releases in context of 0.29.0, but this PR will be included in the next 0.30.0 release! Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Windows API Integration
The program interacts with the Windows API using syscalls to access low-level TCP information:
It loads the iphlpapi.dll library and uses the GetExtendedTcpTable function to retrieve TCP connection information.
The MIB_TCPROW_OWNER_PID struct is defined to represent a row in the TCP connection table.