This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Update head time when reading wal #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2018 12:38
Signed-off-by: Krasi Georgiev <[email protected]>
Signed-off-by: Krasi Georgiev <[email protected]>
|
Those changes probably conflict with #332. Coincidentally I ran into the same bug when doing it and already fixed it there along with other changes: https://github.com/prometheus/tsdb/pull/332/files#diff-0ced3454d447442a96a77b33ebe87300R233 |
|
@fabxc yes I noticed , but it seems that the update for the head mint is still missing? |
|
@gouthamve @krasi-georgiev is this causing any imminent issues? I've a change fixing and testing this properly, but it is based on #332 – we want a Prometheus release before we merge that. |
|
@fabxc not causing any issues so far. I wanted to keep it just as reminder after you merge the new wall. |
|
superseded by #339 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading he WAL head mint and maxt didn't get updated.
@gouthamve found this bug I am just submitting it on his behalf.