Allow expiration of silences that exceed max size

Signed-off-by: George Robinson <[email protected]>
prometheus · May 31, 2024 · ada0127 · ada0127
1 parent e5fee2b
commit ada0127
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/silence/silence.go b/silence/silence.go
@@ -583,7 +583,7 @@ func (s *Silences) setSilence(sil *pb.Silence, now time.Time, skipValidate bool)
 		return err
 	}
 
-	if n := msil.Size(); s.limits.MaxPerSilenceSize > 0 && n > s.limits.MaxPerSilenceSize {
+	if n := msil.Size(); s.limits.MaxPerSilenceSize > 0 && n > s.limits.MaxPerSilenceSize && sil.EndsAt.After(now) {
 		return fmt.Errorf("silence exceeded maximum size: %d", s.limits.MaxPerSilenceSize)
 	}