amtool no longer takes duration units greater than hours #1183
Comments
sinkingpoint
changed the title
|
It should be fairly easy to re-introduce the behavior again -- take the durations as a string, and parse. Sorry for the regression! |
|
Hah. No problem - that was a monster PR to review! I'll probably throw something together tomorrow London time, if this hasn't been picked up by then. |
|
No worries, I got it |
stuartnelson3
added a commit
that referenced
this issue
Jan 9, 2018
* Fixes #1183 * Update expires comment The default time is already output thanks to kingpin.
hh
pushed a commit
to ii/alertmanager
that referenced
this issue
Dec 20, 2018
Signed-off-by: tariqibrahim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What did you do?
What did you expect to see?
A silence being created
What did you see instead? Under which circumstances?
We believe this is a regression introduced by #976 which changes the type of the cli arguments. Before this commit we took Strings and them parsed to them to Durations (The internal model, not the std lib one) ourselves. This PR instead takes std lib Durations which, according to the docs only support units up to hours.
Considering it's reasonably common to want to silence an alert for a day, or a week, or more, having to convert this into hours is tedious.
The text was updated successfully, but these errors were encountered: