Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in annotations - support relative URLs #1826

Open
xkilian opened this issue Apr 4, 2019 · 0 comments
Open

Links in annotations - support relative URLs #1826

xkilian opened this issue Apr 4, 2019 · 0 comments

Comments

@xkilian
Copy link

xkilian commented Apr 4, 2019

What did you do?
Create two annotations with a url:
https://web.url.com/
/relative/url/path

What did you expect to see?
For both to be converted to a linkified URL link and displayed as the link icon

What did you see instead? Under which circumstances?
The first is converted because as #884 and the pull request #946 implemented it looks for things starting with http(s)://
The second obviously did not convert to a linkified URL and displays as a simple annotation. There should be a way to specify relative path URLS. This breaks implementations that are behind proxies that rewrite the FQDN of the URL and all other reasons for using relative versus absolute urls...

Please provide a way to permit relative URLs in annotations that will be linkified. Either a keyword in the annotation name or some type of markup to indicate that a url will follow in the annotation itself.

Environment
Prometheus 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants