Linkify annotations #946
Merged
Linkify annotations #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested changes
Aug 13, 2017
ui/app/src/Utils/Views.elm
Outdated
| (\result -> | ||
| case result of | ||
| Ok link -> | ||
| a [ href link ] [ text link ] |
There was a problem hiding this comment.
Could you add target "blank" here?
mxinden
approved these changes
Aug 13, 2017
iksaif
pushed a commit
to iksaif/alertmanager
that referenced
this pull request
Sep 15, 2017
* Make links in annotations clickable * Update test script and bindata.go * Add target = _blank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr partially addresses #884 by making the links in annotations clickable. I'm not sure that the links in labels should be clickable, I think it would be too much and might affect the rendering performance of the alert list.
The implementation is rather simple: I'm splitting the text by words, then checking if a word starts with
http(s)://. This means each link should be surrounded by a whitespace.