-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generally enable reading secrets from files #2498
Comments
Some fields we are missing: smtp_auth_password_file |
- Added support for the file in both the global and the lower level - Tried to follow configuration patterns I saw in prometheus - The slack file is read on every request as mentioned in the prometheus issue to enable seamless switches prometheus#2498
- Added support for the file in both the global and the lower level - Tried to follow configuration patterns I saw in prometheus - The slack file is read on every request as mentioned in the prometheus issue to enable seamless switches prometheus#2498 Signed-off-by: Julien Duchesne <[email protected]>
When can we expect to have configuration for |
I guess the implementation for all the other fields will follow the same pattern as #2534. PRs welcome. 😃 |
Would anyone object to a general case of something like |
That would collide with any secret that happens to start with I guess including a "schema" from the beginning would have been the best solution ( We could switch to such a generic solution with AM, in principle, because we are still pre 1.x, but on the other hand, keeping things consistent with Prometheus (where we cannot change easily) has its value, too. Just my random thoughts… |
There are a few more not mentioned above:
|
I like to have multiple keys. Having file: would just lead to more yaml issues for new users. |
I found a workaround for Opsgenie, Pagerduty and Pushover: While coding #2728 I detect a hidden functionality inside Alertmanager. I saw this functionally for pagerduty and pushover
All properties are piped through Alertmanager template engine. A possible workaround would be to define template (this can be a file on the filesystem, maybe mounted through an kubernetes secret) a like:
And inside the configuration of Aertmanager, use this template inside the configuration:
That could be a workaround some users. Except for VictorOps. |
It would be nice to use the feature #2728. Any plans on doing a release soon? |
I was so happy while reading this workaround unfortunately it doesn't work for smtp configuration. https://github.com/prometheus/alertmanager/blob/main/notify/email/email.go#L103 really hope #3038 will be accepted and available. |
Add the user_key_file and token_file keys to the pushover config. /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
Add the user_key_file and token_file keys to the pushover config. /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
* support loading pushover secrets from files Add the user_key_file and token_file keys to the pushover config. /cc #2498 Signed-off-by: Simon Rozet <[email protected]>
/cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
/cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
* support loading webhook URL from a file /cc #2498 Signed-off-by: Simon Rozet <[email protected]> * notify/webhook: add test for reading url from file Signed-off-by: Simon Rozet <[email protected]> * notify/pushover: add tests for reading secrets from files Signed-off-by: Simon Rozet <[email protected]> --------- Signed-off-by: Simon Rozet <[email protected]>
* support loading pushover secrets from files Add the user_key_file and token_file keys to the pushover config. /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
* support loading webhook URL from a file /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]> * notify/webhook: add test for reading url from file Signed-off-by: Simon Rozet <[email protected]> * notify/pushover: add tests for reading secrets from files Signed-off-by: Simon Rozet <[email protected]> --------- Signed-off-by: Simon Rozet <[email protected]>
* support loading pushover secrets from files Add the user_key_file and token_file keys to the pushover config. /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]>
* support loading webhook URL from a file /cc prometheus#2498 Signed-off-by: Simon Rozet <[email protected]> * notify/webhook: add test for reading url from file Signed-off-by: Simon Rozet <[email protected]> * notify/pushover: add tests for reading secrets from files Signed-off-by: Simon Rozet <[email protected]> --------- Signed-off-by: Simon Rozet <[email protected]>
This is the same as prometheus/prometheus#8551 , just for Alertmanager.
The text was updated successfully, but these errors were encountered: