Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement missing parameters for pushover, such as ttl #3454

Closed
FrederikNJS opened this issue Aug 9, 2023 · 3 comments
Closed

Comments

@FrederikNJS
Copy link

What did you do?

I used the pushover receiver, and tried to add the ttl parameter, but alertmanager didn't recognize the setting.

What did you expect to see?

I expected alertmanager to allow me to use any parameter that pushover supports: https://pushover.net/api

What did you see instead? Under which circumstances?

As mentioned above alertmanager crashes on launch, explaining that it doesn't recognize the ttl parameter.

Environment

  • System information:

    $ uname -srm
    Linux 6.1.0-3-amd64 x86_64

  • Alertmanager version:

    $ alertmanager --version
    alertmanager, version 0.25.0 (branch: HEAD, revision: 258fab7)
    build user: root@abe866dd5717
    build date: 20221222-14:51:36
    go version: go1.19.4
    platform: linux/amd64

  • Prometheus version:

    I'm not using prometheus, but victoria-metrics 1.91.4

  • Alertmanager configuration file:

global:
  resolve_timeout: 5m
route:
  receiver: 'pushover'
  repeat_interval: 1h
  routes:
  - match:
      alertname: Watchdog
    receiver: "null"
  - match:
      alertname: InfoInhibitor
    receiver: "null"
receivers:
- name: "null"
- name: 'pushover'
  pushover_configs:
  - user_key: "{{ index . "pushover_key" }}"
    token: "{{ index . "token" }}"
    priority: '0'
    ttl: 3600
    send_resolved: false
  • Prometheus configuration file:
Not really relevant
  • Logs:
ts=2023-08-09T09:49:40.054Z caller=main.go:240 level=info msg="Starting Alertmanager" version="(version=0.25.0, branch=HEAD, revision=258fab7cdd551f2cf251ed0348f0ad7289aee789)"                                                                                                                                                                                             
ts=2023-08-09T09:49:40.054Z caller=main.go:241 level=info build_context="(go=go1.19.4, user=root@abe866dd5717, date=20221222-14:51:36)"                                                                                                                                                                                                                                      
ts=2023-08-09T09:49:40.350Z caller=coordinator.go:113 level=info component=configuration msg="Loading configuration file" file=/etc/alertmanager/config/alertmanager.yaml                                                                                                                                                                                                    
ts=2023-08-09T09:49:40.353Z caller=coordinator.go:118 level=error component=configuration msg="Loading configuration file failed" file=/etc/alertmanager/config/alertmanager.yaml err="yaml: unmarshal errors:\n  line 23: field ttl not found in type config.plain"
@gotjosh
Copy link
Member

gotjosh commented Aug 9, 2023

In the Alertmanager, we try to use the conservative approach of only including what is needed at the moment as such, we don't aim to provide a 1:1 feature parity with our integration (that would be too much burden on the only two active mantainers 😄)

With that said, I'd be happy to accept a PR that includes this feature. Feel free to take a look at #3318 as example.

@heliapb
Copy link
Contributor

heliapb commented Aug 23, 2023

Hi @gotjosh I would like to work on this issue, could you please assign it to me?

@chrko
Copy link

chrko commented Aug 5, 2024

I think that has been implemented in #3474 and therefore can be closed.

@gotjosh gotjosh closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants