-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pushover devices #3318
Add support for pushover devices #3318
Conversation
2c566a6
to
05d2da7
Compare
Hi, @simonpasquier @w0rm @gotjosh can one of you review this when you get chance please, it's a simple addition and I've tested it, thanks 😃. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you also update the documentation in docs/configuration.md?
Am I correct in assuming that when device
is empty then the notification is sent to all devices?
Signed-off-by: Alec Pinson <[email protected]>
Signed-off-by: Alec Pinson <[email protected]>
57995d7
to
53cbb72
Compare
You are correct! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Anything else @simonpasquier ? |
* Add support for pushover devices Signed-off-by: Alec Pinson <[email protected]> * update docs Signed-off-by: Alec Pinson <[email protected]> --------- Signed-off-by: Alec Pinson <[email protected]>
* Add support for pushover devices Signed-off-by: Alec Pinson <[email protected]> * update docs Signed-off-by: Alec Pinson <[email protected]> --------- Signed-off-by: Alec Pinson <[email protected]>
Extending Pushover integration to allow for
device
parameter to be used.https://pushover.net/api#device