Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpsGenie Priority field #1094

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

Tom-Fawcett
Copy link
Contributor

Now that Alertmanager is on the OpsGenie v2 API we can use the "Priority" field.

This is a non-mandatory field described as follows:

Priority level of the alert. Possible values are P1, P2, P3, P4 and P5. Default value is P3.

Further information about this field can be found here, including information on validation:

If an unknown value is assigned or the tool does not carry a priority information, the alert will have the default priority value, P3.

With the above in mind, this PR does not validate the value for this field. Though I could add validation if so desired.

Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. If there's confusion we can add validation later.

@stuartnelson3 stuartnelson3 merged commit fd0ace8 into prometheus:master Nov 12, 2017
@Tom-Fawcett
Copy link
Contributor Author

Thanks :)

hh pushed a commit to ii/alertmanager that referenced this pull request Oct 4, 2018
Starting with (not yet released) OpenBSD 6.4, sysctl KERN_CPTIME2 will
return ENODEV for offline CPUs.

SMT siblings are reported as offline when hw.smt is disabled, which is
the default since one of the later Spectre variants. So this might
affect a few systems.

For more details see:
https://cvsweb.openbsd.org/src/sys/kern/kern_sysctl.c#rev1.348

Signed-off-by: Ralf Horstmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants