UI: Fix JavaScript error in MSIE due to endswith() usage #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSIE does not support endswith() [1]. substr() can be used to work around this limitation. [1] https://docs.microsoft.com/en-us/scripting/javascript/reference/endswith-method-string-javascript
w0rm
approved these changes
Dec 30, 2017
|
@hoffie thanks for your contribution! |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 30, 2018
* Add fallback for missing /proc/1/mounts On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]> * Add tests. Signed-off-by: Ben Kochie <[email protected]> * Add CHANGELOG entry. Signed-off-by: Ben Kochie <[email protected]>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 30, 2018
* collector/diskstats: don't fail if there are extra stats, just ignore… (prometheus#1125) * collector/diskstats: don't fail if there are extra stats, just ignore them Signed-off-by: Paul Gier <[email protected]> Signed-off-by: Ben Kochie <[email protected]> * collector/hwmon_linux: handle temperature sensor file which doesn't have item suffix (prometheus#1123) In some cases the file might be called "temp" instead of the usual format "temp<index>_<item>" as described in the kernel docs: https://www.kernel.org/doc/Documentation/hwmon/sysfs-interface In this case, treat this as an _input file containing the current temperature reading. Fixes prometheus#1122 Signed-off-by: Paul Gier <[email protected]> Signed-off-by: Ben Kochie <[email protected]> * Handle 'Unknown' as measurement value. (prometheus#1113) We use the output-compatible perccli and storcli.py does not handle 'Unknown' as a result: ``` sg="Error parsing \"/var/lib/node_exporter/perccli.prom\": text format parsing error in line 222: expected float as value, got \"Unknown\"" source="textfile.go:212" ``` I know, the perccli should not return 'Unknown' but this error breaks all other useful measurements because the prom file is not parsable. My if condition fixes this. Signed-off-by: Andreas Wirooks <[email protected]> Signed-off-by: Ben Kochie <[email protected]> * circleci: switch to 2.1 config Signed-off-by: Ben Kochie <[email protected]> * Convert to Go modules (prometheus#1178) * Convert to Go modules * Update promu config. * Convert to Go modules. * Update vendoring. * Update Makefile.common. * Update circleci config. * Use Prometheus release tar for promtool. * Fixup unpack * Use temp dir for unpacking tools. * Use BSD compatible tar command. * OpenBSD mkdir doesn't support `-v`. Signed-off-by: Ben Kochie <[email protected]> * Add fallback for missing /proc/1/mounts (prometheus#1172) * Add fallback for missing /proc/1/mounts On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]> * Add tests. Signed-off-by: Ben Kochie <[email protected]> * Add CHANGELOG entry. Signed-off-by: Ben Kochie <[email protected]> * Release v0.17.0 (prometheus#1168) * Update CHANGELOG * Update VERSION Signed-off-by: Ben Kochie <[email protected]>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Dec 3, 2018
* Add fallback for missing /proc/1/mounts On some systems, `/proc/1/mounts` is hidden from non-root users due to the `hidepid` procfs feature. Attempt to fallback to `/proc/mounts` if `/proc/1/mounts` is not found. Signed-off-by: Ben Kochie <[email protected]> * Add tests. Signed-off-by: Ben Kochie <[email protected]> * Add CHANGELOG entry. Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSIE does not support endswith() [1]. substr() can be used to work around this limitation.
@stuartnelson3: Could this be merged?
[1] https://docs.microsoft.com/en-us/scripting/javascript/reference/endswith-method-string-javascript