notify: notify resolved alerts properly #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR prometheus#1205 while fixing an existing issue introduced another bug when the send_resolved flag of the integration is set to true. With send_resolved set to false, the semantics remain the same: AlertManager generates a notification when new firing alerts are added to the alert group. The notification only carries firing alerts. With send_resolved set to true, AlertManager generates a notification when new firing or resolved alerts are added to the alert group. The notification carries both the firing and resolved notifications. Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
fix-resolved-notif2
branch
from
90af009 to
3761608
Compare
stuartnelson3
suggested changes
Jun 7, 2018
notify/notify_test.go
Outdated
| resolvedAlerts: alertHashSet(2, 3, 4), | ||
| res: false, | ||
| }, { | ||
| // Different sets of firing alarms should update. |
There was a problem hiding this comment.
Could you update alarms in this comment and all the others to alerts? Super nit-picky, sorry !
There was a problem hiding this comment.
No problem. Not sure why I wrote "alarms" here...
Signed-off-by: Simon Pasquier <[email protected]>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Jul 1, 2019
Signed-off-by: yosefy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1403.
I've described the change in the commit message but I feel that an update to the docs would be helpful too. I'm still testing it locally to explore with different alert scenarios.