Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispatch: use strings.Builder instead of []byte #1963

Merged
merged 1 commit into from
Jul 16, 2019
Merged

dispatch: use strings.Builder instead of []byte #1963

merged 1 commit into from
Jul 16, 2019

Conversation

simonpasquier
Copy link
Member

No description provided.

mxinden
mxinden approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess given that strings.Builder just uses a []bytes underneath, this is more a syntactic change, right? Don't get me wrong, I think it is worth it.

stuartnelson3
stuartnelson3 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool to me

@simonpasquier
Copy link
Member Author

@mxinden totally correct. I was working on some other change and thought it would be a bit cleaner this way.

@mxinden mxinden merged commit 4706dc7 into prometheus:master Jul 16, 2019
@simonpasquier simonpasquier deleted the refactor-dispatch-route branch July 16, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartnelson3 stuartnelson3 stuartnelson3 approved these changes

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonpasquier @stuartnelson3 @mxinden