Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move walkRoute to dispatch package. #2136

Merged
merged 1 commit into from
Dec 20, 2019
Merged

move walkRoute to dispatch package. #2136

merged 1 commit into from
Dec 20, 2019

Conversation

johncming
Copy link
Contributor

move walkRoute to dispatch package for better encapsulation and add test case.

simonpasquier
simonpasquier reviewed Dec 11, 2019
View reviewed changes
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, LGTM otherwise.

dispatch/route_test.go Outdated Show resolved Hide resolved
dispatch/route_test.go Outdated Show resolved Hide resolved
dispatch/route_test.go Outdated Show resolved Hide resolved
@simonpasquier
Copy link
Member

The DCO is failing.

@johncming
Copy link
Contributor Author

The DCO is failing.

@simonpasquier fixed

@simonpasquier
Copy link
Member

Please remove this comment and it will be good to go. Thanks!

@simonpasquier
Copy link
Member

Thanks!

@simonpasquier simonpasquier merged commit 134c3c0 into prometheus:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johncming @simonpasquier