Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redirect on / to routePrefix #2235

Merged
merged 1 commit into from
May 28, 2020
Merged

Add redirect on / to routePrefix #2235

merged 1 commit into from
May 28, 2020

Conversation

LucasBoisserie
Copy link
Contributor

@LucasBoisserie LucasBoisserie commented Apr 17, 2020 •
edited
Loading

When routePrefix is set alertmanager doesn't redirect traffic from / to target routePrefix
Prometheus implemented it with an http redirect to targeted routePrefix, here

Add the same code, to have the same comportement

@LucasBoisserie
Add redirect on / to routePrefix
a14a589 
Signed-off-by: LucasBoisserie <[email protected]>
@LucasBoisserie LucasBoisserie marked this pull request as ready for review April 17, 2020 17:01
paulfantom
paulfantom approved these changes Apr 21, 2020
View reviewed changes
Copy link

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roidelapluie roidelapluie self-assigned this May 21, 2020
@simonpasquier simonpasquier merged commit 97bd078 into prometheus:master May 28, 2020
@simonpasquier
Copy link
Member

Thanks!

@LucasBoisserie LucasBoisserie deleted the redirect_route_prefix branch May 28, 2020 15:15
@roidelapluie roidelapluie removed their assignment Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom paulfantom approved these changes

@simonpasquier simonpasquier simonpasquier approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasBoisserie @simonpasquier @paulfantom @roidelapluie