Marker: Rename SetSilenced to SetActiveOrSilenced
#2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accurately reflects what the function _actually_ does. If no active silences IDs are provided and the list of inhibitions we have is already empty the alert is actually set to Active. Took me a while to realise this as I was understanding how do we populate the alert list. Signed-off-by: gotjosh <[email protected]>
gotjosh
force-pushed
the
change-set-silenced-func-name
branch
from
66044d0 to
cfb909f
Compare
Signed-off-by: gotjosh <[email protected]>
gotjosh
force-pushed
the
change-set-silenced-func-name
branch
from
ec0023f to
f66bbab
Compare
roidelapluie
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accurately reflects what the function actually does. If no active silences IDs are provided and the list of inhibitions we have is already empty the alert is actually set to Active. Took me a while to realise this as I was understanding how do we populate the alert list.
While doing #2943 I was a bit puzzled as to where the active alerts are first introduced to
memMarker, after carefully reading the interface I realised that a function namedSetSilencedis actually used for that (!!). I'm not sure what our policy is and technically can be considered a breaking change so I'd like to hear opinions on whether this is worth it or not? At the very least the interface documentation is clear about it if we decided not to do this.