Bump prometheus/common to v0.52.3 #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is stopping us from updating prometheus/common in our repo; would be great to see it merged. |
grobinson-grafana
force-pushed
the
grobinson/update-prometheus-common
branch
from
deb9b02 to
4ade5cc
Compare
This commit bumps prometheus/common to v0.52.3. It has a breaking change where the metric alertmanager_build_info has been renamed to go_build_info as the metric has been moved from prometheus/common to prometheus/client_golang and the namspace argument has been removed. Signed-off-by: George Robinson <[email protected]>
grobinson-grafana
force-pushed
the
grobinson/update-prometheus-common
branch
from
4ade5cc to
88943ca
Compare
Signed-off-by: George Robinson <[email protected]>
Signed-off-by: George Robinson <[email protected]>
TheMeier
pushed a commit
to TheMeier/alertmanager
that referenced
this pull request
May 3, 2024
* Bump prometheus/common to v0.52.3 This commit bumps prometheus/common to v0.52.3. It has a breaking change where the metric alertmanager_build_info has been renamed to go_build_info as the metric has been moved from prometheus/common to prometheus/client_golang and the namspace argument has been removed. --------- Signed-off-by: George Robinson <[email protected]>
TheMeier
pushed a commit
to TheMeier/alertmanager
that referenced
this pull request
Sep 29, 2024
* Bump prometheus/common to v0.52.3 This commit bumps prometheus/common to v0.52.3. It has a breaking change where the metric alertmanager_build_info has been renamed to go_build_info as the metric has been moved from prometheus/common to prometheus/client_golang and the namspace argument has been removed. --------- Signed-off-by: George Robinson <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Dec 18, 2024
Use the new version collector to expose the `alertmanager_build_info` metric. This fixes an incorrect deprecation migration done in #3806. Signed-off-by: SuperQ <[email protected]>
Merged
gogetdane
pushed a commit
to gogetdane/alertmanager
that referenced
this pull request
Jan 24, 2025
Use the new version collector to expose the `alertmanager_build_info` metric. This fixes an incorrect deprecation migration done in prometheus#3806. Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bumps prometheus/common to
v0.52.3. It has a breaking change where the metricalertmanager_build_infohas been renamed togo_build_infoas the metric has been moved fromprometheus/commontoprometheus/client_golangand thenamspaceargument has been removed.