Implement silence create/read/update/delete API and UI workflow. #5

juliusv · 2013-07-25T22:24:20Z

It's not perfect yet (for example, silence filters look ugly in the overview), but this changeset is growing quite big, so I'll fix that later.

juliusv · 2013-07-25T23:44:47Z

You might notice that currently the translation between the naming of "silence" vs. "suppression" happens in the server-side API. I'd suggest consolidating them to a common term in the future, which in my preference would be "silence", since it sounds more pleasant to me than "suppression".

matttproud · 2013-07-26T06:54:41Z

manager/event.go

@@ -19,15 +19,27 @@ import (
 	"sort"
 )

+const (


If just one, no ().

matttproud · 2013-07-26T07:05:41Z

Go ahead and s,Suppression,Silence,g or s,Suppression,Inhibit,g. My personal inclination is toward the latter since we are effectively building workflows from events, and it's not always sensible that a workflow should be silenced but rather inhibited.

grobie · 2013-07-26T07:31:23Z

Small vote vor silence, I guess I can get used to inhibit, but silence
seems to be the term which is more often used in that context. (And it's
easier to understand for non-english speaker)
On Jul 26, 2013 2:05 PM, "Matt T. Proud" [email protected] wrote:

Go ahead and s,Suppression,Silence,g or s,Suppression,Inhibit,g. My
personal inclination is toward the latter since we are effectively building
workflows from events, and it's not always sensible that a workflow should
be silenced but rather inhibited.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-21604861
.

juliusv · 2013-07-26T09:50:54Z

@matttproud @grobie I think silences and inhibits are conceptually different things.

A silence is an explicitly created entity with set expiry time and explicit set of filter labels.

An inhibit is a dynamic side-effect of alert dependency rules, e.g. "if currently an alert of type A is firing for a zone, inhibit notifications for alert B in the same zone".

Both end up silencing/inhibiting notifications, but they work otherwise very differently under the hood.

juliusv · 2013-07-26T10:42:53Z

Addressed comments, PTAL. Will do the internal suppression renaming in a later change, and once there is a common understanding around the concepts.

juliusv · 2013-07-26T14:08:28Z

Merging this silence editing PR. If there are any more followup comments, I'll address them in a new PR.

Implement silence create/read/update/delete API and UI workflow.

…duty (bug): added pagerduty events URL to testReceiver

* feat: ms teams initial version * fix: solved issues found during ms teams testing * fix: added retry code for ms teams sender

Addresses: Scanning your code and 410 packages across 83 dependent modules for known vulnerabilities... === Symbol Results === Vulnerability prometheus#1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Example traces found: prometheus#1: cli/root.go:122:52: cli.NewAlertmanagerClient calls config.NewClientFromConfig, which eventually calls http2.ConfigureTransports prometheus#2: types/types.go:290:28: types.MultiError.Error calls http2.ConnectionError.Error prometheus#3: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.ErrCode.String prometheus#4: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.FrameHeader.String prometheus#5: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.FrameType.String prometheus#6: types/types.go:290:28: types.MultiError.Error calls http2.GoAwayError.Error prometheus#7: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.Setting.String prometheus#8: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.SettingID.String prometheus#9: types/types.go:290:28: types.MultiError.Error calls http2.StreamError.Error prometheus#10: api/v2/client/silence/silence_client.go:196:35: silence.Client.PostSilences calls client.Runtime.Submit, which eventually calls http2.Transport.NewClientConn prometheus#11: api/v2/client/silence/silence_client.go:196:35: silence.Client.PostSilences calls client.Runtime.Submit, which eventually calls http2.Transport.RoundTrip prometheus#12: notify/email/email.go:253:14: email.Email.Notify calls fmt.Fprintf, which eventually calls http2.chunkWriter.Write prometheus#13: types/types.go:290:28: types.MultiError.Error calls http2.connError.Error prometheus#14: types/types.go:290:28: types.MultiError.Error calls http2.duplicatePseudoHeaderError.Error prometheus#15: test/cli/acceptance.go:362:3: cli.Alertmanager.Start calls http2.gzipReader.Close prometheus#16: test/cli/acceptance.go:366:22: cli.Alertmanager.Start calls io.ReadAll, which calls http2.gzipReader.Read prometheus#17: types/types.go:290:28: types.MultiError.Error calls http2.headerFieldNameError.Error prometheus#18: types/types.go:290:28: types.MultiError.Error calls http2.headerFieldValueError.Error prometheus#19: api/v2/client/silence/silence_client.go:196:35: silence.Client.PostSilences calls client.Runtime.Submit, which eventually calls http2.noDialH2RoundTripper.RoundTrip prometheus#20: types/types.go:290:28: types.MultiError.Error calls http2.pseudoHeaderError.Error prometheus#21: notify/email/email.go:253:14: email.Email.Notify calls fmt.Fprintf, which eventually calls http2.stickyErrWriter.Write prometheus#22: test/cli/acceptance.go:362:3: cli.Alertmanager.Start calls http2.transportResponseBody.Close prometheus#23: test/cli/acceptance.go:366:22: cli.Alertmanager.Start calls io.ReadAll, which calls http2.transportResponseBody.Read prometheus#24: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.writeData.String Your code is affected by 1 vulnerability from 1 module. This scan also found 0 vulnerabilities in packages you import and 2 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities. Use '-show verbose' for more details. Signed-off-by: Holger Hans Peter Freyther <[email protected]>

Addresses: Scanning your code and 410 packages across 83 dependent modules for known vulnerabilities... === Symbol Results === Vulnerability #1: GO-2024-2687 HTTP/2 CONTINUATION flood in net/http More info: https://pkg.go.dev/vuln/GO-2024-2687 Module: golang.org/x/net Found in: golang.org/x/[email protected] Fixed in: golang.org/x/[email protected] Example traces found: #1: cli/root.go:122:52: cli.NewAlertmanagerClient calls config.NewClientFromConfig, which eventually calls http2.ConfigureTransports #2: types/types.go:290:28: types.MultiError.Error calls http2.ConnectionError.Error #3: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.ErrCode.String #4: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.FrameHeader.String #5: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.FrameType.String #6: types/types.go:290:28: types.MultiError.Error calls http2.GoAwayError.Error #7: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.Setting.String #8: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.SettingID.String #9: types/types.go:290:28: types.MultiError.Error calls http2.StreamError.Error #10: api/v2/client/silence/silence_client.go:196:35: silence.Client.PostSilences calls client.Runtime.Submit, which eventually calls http2.Transport.NewClientConn #11: api/v2/client/silence/silence_client.go:196:35: silence.Client.PostSilences calls client.Runtime.Submit, which eventually calls http2.Transport.RoundTrip #12: notify/email/email.go:253:14: email.Email.Notify calls fmt.Fprintf, which eventually calls http2.chunkWriter.Write #13: types/types.go:290:28: types.MultiError.Error calls http2.connError.Error #14: types/types.go:290:28: types.MultiError.Error calls http2.duplicatePseudoHeaderError.Error #15: test/cli/acceptance.go:362:3: cli.Alertmanager.Start calls http2.gzipReader.Close #16: test/cli/acceptance.go:366:22: cli.Alertmanager.Start calls io.ReadAll, which calls http2.gzipReader.Read #17: types/types.go:290:28: types.MultiError.Error calls http2.headerFieldNameError.Error #18: types/types.go:290:28: types.MultiError.Error calls http2.headerFieldValueError.Error #19: api/v2/client/silence/silence_client.go:196:35: silence.Client.PostSilences calls client.Runtime.Submit, which eventually calls http2.noDialH2RoundTripper.RoundTrip #20: types/types.go:290:28: types.MultiError.Error calls http2.pseudoHeaderError.Error #21: notify/email/email.go:253:14: email.Email.Notify calls fmt.Fprintf, which eventually calls http2.stickyErrWriter.Write #22: test/cli/acceptance.go:362:3: cli.Alertmanager.Start calls http2.transportResponseBody.Close #23: test/cli/acceptance.go:366:22: cli.Alertmanager.Start calls io.ReadAll, which calls http2.transportResponseBody.Read #24: notify/notify.go:998:21: notify.TimeActiveStage.Exec calls log.jsonLogger.Log, which eventually calls http2.writeData.String Your code is affected by 1 vulnerability from 1 module. This scan also found 0 vulnerabilities in packages you import and 2 vulnerabilities in modules you require, but your code doesn't appear to call these vulnerabilities. Use '-show verbose' for more details. Signed-off-by: Holger Hans Peter Freyther <[email protected]>

Signed-off-by: clyang82 <[email protected]>

Implement silence create/read/update/delete API and UI workflow.

ba22478

ghost assigned matttproud Jul 25, 2013

matttproud reviewed Jul 26, 2013
View reviewed changes

PR comment fixups.

9b1a5aa

juliusv added a commit that referenced this pull request Jul 26, 2013

Merge pull request #5 from prometheus/refactor/editable-silences

3f9cc9e

Implement silence create/read/update/delete API and UI workflow.

juliusv merged commit 3f9cc9e into master Jul 26, 2013

juliusv deleted the refactor/editable-silences branch July 26, 2013 14:08

gotjosh mentioned this pull request Jun 28, 2022

Ensure matcher values are present when parsing matchers from strings #2968

Merged

mindhash pushed a commit to mindhash/alertmanager that referenced this pull request Jul 18, 2022

Merge pull request prometheus#5 from mindhash/amol/test-channel-pager…

6f8c41a

…duty (bug): added pagerduty events URL to testReceiver

srikanthccv pushed a commit to SigNoz/am that referenced this pull request Aug 25, 2023

feat: ms teams initial version (prometheus#5)

cd6f9ed

* feat: ms teams initial version * fix: solved issues found during ms teams testing * fix: added retry code for ms teams sender

saswatamcode pushed a commit to saswatamcode/alertmanager that referenced this pull request Jun 17, 2024

Introduce BUILD_PROMU variable (prometheus#5)

8f7b03f

Signed-off-by: clyang82 <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement silence create/read/update/delete API and UI workflow. #5

Implement silence create/read/update/delete API and UI workflow. #5

juliusv commented Jul 25, 2013

juliusv commented Jul 25, 2013

matttproud Jul 26, 2013

juliusv Jul 26, 2013

matttproud commented Jul 26, 2013

grobie commented Jul 26, 2013

juliusv commented Jul 26, 2013

juliusv commented Jul 26, 2013

juliusv commented Jul 26, 2013

@@ @@ -19,15 +19,27 @@ import ( @@
               	"sort"
               )
+              const (

Implement silence create/read/update/delete API and UI workflow. #5

Implement silence create/read/update/delete API and UI workflow. #5

Conversation

juliusv commented Jul 25, 2013

juliusv commented Jul 25, 2013

matttproud Jul 26, 2013

Choose a reason for hiding this comment

juliusv Jul 26, 2013

Choose a reason for hiding this comment

matttproud commented Jul 26, 2013

grobie commented Jul 26, 2013

juliusv commented Jul 26, 2013

juliusv commented Jul 26, 2013

juliusv commented Jul 26, 2013