-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show alert annotations #833
Conversation
@mxinden @stuartnelson3 this bindata stuff is annoying. It produces different file locally, even when I pull the latest golang docker and do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but there's a bug -- it seems that the maybeActiveIndex
ends up showing the annotations for all alerts at index idx
, even if they're separated into different groups.
So if we separate groups by alertname
and dev
, if I click index == 0 in the first group, it shows annotation data at index == 0 in all groups.
I've attached the time traveling debugger things for you to see:
index_per_group.txt
@stuartnelson3 oh I see. it would be nice if alerts had ids so we didn't have to rely on index |
@stuartnelson3 if we're going to add this field, will it be named |
Is it possible to finish this PR without adding id to the alert object for now? If so, can we move the AlertID discussion to this issue #681 |
@mxinden I think it's fine to enhance alerts with local ids. We will just have to fix the decoder, and it will still work. Please re-review my changes. Also, I fixed the decoding of silenced status, it actually works now and links to the first silence in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thanks for the quick adjustments!
@stuartnelson3 @mxinden sorry for the misinformation, it was the same problem of updated |
* Use go 1.10 * Use latest aktau/github-release
Closes #821