Stn/status page ohne mesh #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A mesh connection was assumed, even though the value that was being passed into the helper function was a possibly-nil pointer. Add a check for this, and return a nil value in that case. The frontend finds this when decoding the json payload, and displays the "not configured" message.
mxinden
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
Thanks for the improvement!
Just for others to test this: you need to set -mesh.listen-address="", because it defaults to 0.0.0.0 by default.
@stuartnelson3 Do you know why we default to an address instead of not initializing the mesh by default?
|
I'm not sure, but I believe the default is for a server to start a mesh with itself. That way, other servers can be brought up that will connect to this initial server. |
|
@stuartnelson3 Sounds reasonable. Thanks. |
|
Fixes #918 |
w0rm
approved these changes
Jul 22, 2017
iksaif
pushed a commit
to iksaif/alertmanager
that referenced
this pull request
Sep 15, 2017
* Render status page without mesh connection (prometheus#918) A mesh connection was assumed, even though the value that was being passed into the helper function was a possibly-nil pointer. Add a check for this, and return a nil value in that case. The frontend finds this when decoding the json payload, and displays the "not configured" message. * Update bindata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this look?