Stn/edit on silence view page #970
Conversation
| update : SilenceViewMsg -> Model -> String -> ( Model, Cmd SilenceViewMsg ) | ||
| update msg model basePath = | ||
| update : SilenceViewMsg -> Model -> String -> String -> ( Model, Cmd SilenceViewMsg ) | ||
| update msg model basePath apiUrl = |
There was a problem hiding this comment.
Looks like the basePath argument isn't used.
|
@w0rm can you take a look at the style on the silence view page? the buttons don't really line up with the header, and I'm not sure what to do about it. |
|
@stuartnelson3 sure, I will check this tomorrow! |
|
@stuartnelson3 this would make it look nicer h1 []
[ text "Silence"
, span
[ class "ml-3" ]
[ editButton silence
, deleteButton silence True
]
]
|
|
looks great, updated |
|
@stuartnelson3 Cool, thanks for the fix! I am fine with the |
|
That's what I initially did, but if you have an active filter, redirecting will erase that. If we preserve the filter, we still have to deal with having an unstable silence order currently :/ happy to change this once we have stable silence order. |
* Edit/recreate/destroy silence on view page * Share stuff from SilenceList * Update bindata * Remove unused variable * Update bindata * Update silence style * Update bindata
fixes #794
@w0rm @mxinden I thought about moving the buttons into their own
Views/Shared/SilenceButtons.elmbut decided to wait to see what you thought. The only thing I'm not really happy about is having therefreshbool to indicate "navigate to all silences if on a silence view page, but don't if on the main silences page".