-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid le label value on go_gc_pauses_seconds_total_bucket #995
Labels
Comments
I guess there's a legitimate answer to that in the same thread by @mknyszek #967 (comment) That being said, we could consider an absorbing the negative values here. |
This was referenced Apr 12, 2022
Calculate quantile need bucket include Inf, but main branch has exclude Inf. So quantile return NaN. if someone need a patch, I will pr. |
Fixed with #1049 |
Confirming bug is fixed in 1.12.2. |
ti-mo
added a commit
to ti-mo/cilium
that referenced
this issue
Jun 3, 2022
…e gone" This reverts commit 9febe6b. --- prometheus/client_golang#995 has been solved. Signed-off-by: Timo Beckers <[email protected]>
aanm
pushed a commit
to cilium/cilium
that referenced
this issue
Jun 3, 2022
…e gone" This reverts commit 9febe6b. --- prometheus/client_golang#995 has been solved. Signed-off-by: Timo Beckers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reporting #967 (comment) as a separate issue so it won't get lost
go_gc_pauses_seconds_total_bucket
ends up with a negativele
bucket and aNaN
value forgo_gc_pauses_seconds_total_sum
The text was updated successfully, but these errors were encountered: