-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add with_prefix to Registry #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victor-N-Suadicani
force-pushed
the
prefix
branch
from
July 8, 2022 09:47
efbe835
to
1af568b
Compare
mxinden
reviewed
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments. Thanks for sending in a pull request!
Would you mind adding a changelog entry?
Signed-off-by: Victor Nordam Suadicani <[email protected]>
Co-authored-by: Max Inden <[email protected]> Signed-off-by: Victor Nordam Suadicani <[email protected]>
Signed-off-by: Victor Nordam Suadicani <[email protected]>
Victor-N-Suadicani
force-pushed
the
prefix
branch
from
July 11, 2022 07:38
cd1ec8b
to
23ad729
Compare
mxinden
reviewed
Jul 14, 2022
Signed-off-by: Max Inden <[email protected]>
mxinden
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks!
ackintosh
pushed a commit
to ackintosh/client_rust
that referenced
this pull request
Aug 27, 2022
Signed-off-by: Victor Nordam Suadicani <[email protected]> Signed-off-by: ackintosh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to create a registry with a prefix.
This is actually already possible through the below hack but this makes it a lot easier and neater.
This is useful to set an application-wide prefix on the single registry for all your metrics.