Add a POST form to the landing page #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configuration to the landing page generator to allow a POST form. * Reduce header font size. Signed-off-by: SuperQ <[email protected]>
|
Screenshot example for the snmp_exporter:
|
|
👍 Good enough for this purpose :) If you wanted to avoid the input length business, you could also just put the label and input on separate lines (like it's done in most forms nowadays), but this way is also fine. |
|
Yea, I was just trying to keep the inline format. |
roidelapluie
requested changes
Mar 30, 2023
| <div> | ||
| <form action="{{ .Form.Action}}"> | ||
| {{ range .Form.Inputs }} | ||
| <label>{{ .Label }}:</label> <input type="{{ .Type }}" name="{{ .Name }}" placeholder=" .Placeholder }}" value="{{ .Value }}"><br> |
There was a problem hiding this comment.
{{ is missing for placeholder
|
My comment was still pending.. |
SuperQ
added a commit
that referenced
this pull request
May 1, 2023
* [FEATURE] Client TLS: Add option to require a specific Subject Alternate Names #126 * [FEATURE] Add a POST form to the landing page #144 * [FEATURE] Add generic customization to landing page #146 * [ENHANCEMENT] Add a Content-Type header to the landing page #142 * [BUGFIX] Fix Nil pointer references for WebSystemdSocket #127 Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration to the landing page generator to allow a POST form.