Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch logging to go-kit #108

Closed
brian-brazil opened this issue Sep 23, 2019 · 1 comment · Fixed by #109
Closed

Switch logging to go-kit #108

brian-brazil opened this issue Sep 23, 2019 · 1 comment · Fixed by #109
Labels
enhancement good first issue help wanted

Comments

@brian-brazil
Copy link
Contributor

About two years ago we decided to move from logrus to go-kit for logging, this is one of the repos that still needs switching. prometheus/snmp_exporter#447 is an example PR.
@pohzipohzi pohzipohzi mentioned this issue Oct 2, 2019
Merged
@pohzipohzi
Copy link
Contributor

hey @brian-brazil , I made an update in #109, can you help to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switch logging to go-kit
2 participants
@brian-brazil @pohzipohzi