Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch logging to go-kit #447

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Switch logging to go-kit #447

merged 1 commit into from
Sep 11, 2019

Conversation

brian-brazil
Copy link
Contributor

SuperQ
SuperQ reviewed Sep 4, 2019
View reviewed changes
generator/tree.go Outdated Show resolved Hide resolved
@brian-brazil
Copy link
Contributor Author

Did you have a chance to look at this again?

SuperQ
SuperQ reviewed Sep 10, 2019
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues.

collector_test.go Outdated Show resolved Hide resolved
generator/tree_test.go Outdated Show resolved Hide resolved
@brian-brazil
Switch logging to go-kit
91e22ed 
Signed-off-by: Brian Brazil <[email protected]>
SuperQ
SuperQ approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-brazil brian-brazil merged commit 1972a8d into master Sep 11, 2019
@brian-brazil brian-brazil deleted the promlog branch September 11, 2019 13:12
This was referenced Sep 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@simonpasquier simonpasquier mentioned this pull request Sep 27, 2019
Closed
@matthiasr matthiasr mentioned this pull request Oct 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-brazil @SuperQ