Make TLSConfig constructor public #1661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dustin Hooten <[email protected]>
|
We shouldn't be using this anywhere else yet as it's still pending a security audit, and then baking in a node exporter 1.0 release for a few months. It'll move to common when it's good. |
|
Okay, great. Thanks for the review and the context @brian-brazil. I'll go ahead and close the PR for now. |
|
As I mentioned in the other comment, hack it in to the other PR for now so the rest of it can be reviewed and then we can clean it up before submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dustin Hooten [email protected]
This PR makes the TLSConfig constructor public so that we can vendor it into other prometheus repos to keep TLS configuration consistent.
Specifically, @sharadgaur and I plan to add a TLS option to Alertmanager's gossip protocol (continuing work on prometheus/alertmanager#1819).
It has already been suggested in a comment on the above PR draft that this code should be used as part of that effort: prometheus/alertmanager#1819 (comment)