-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: Statfs_t{} doesn't have a Type field on NetBSD, OpenBSD, or Solaris #523
Conversation
Other projects that import procfs, like node_exporter, apparently build for OSs that don't have Statfs_t.Type. Signed-off-by: Dan Williams <[email protected]>
See https://app.circleci.com/pipelines/github/prometheus/node_exporter/3445/workflows/1ca8faff-eabc-45fd-a7f1-0b07dffd6569/jobs/18019 for the full node_exporter CI failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention for naming these files would be fs_linux.go
and fs_others.go
, see how the naming and tags are done for cpuinfo*.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, this is fine.
@SuperQ I thought about that, but given that FreeBSD/Darwin also have Type, and at least FreeBSD can emulate Linux procfs with the same magic as Linux, didn't seem quite right to make it _linux.go. |
…is (prometheus#523) Other projects that import procfs, like node_exporter, apparently build for OSs that don't have Statfs_t.Type. Signed-off-by: Dan Williams <[email protected]>
Other projects that import procfs, like node_exporter, apparently build for OSs that don't have Statfs_t.Type.
Leads to errors like (for node_exporter):