Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback function bind with object as parameter #7984

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

TAYTS
Copy link
Contributor

@TAYTS TAYTS commented Sep 29, 2020

Fixes #7296: Remove the object parameter in the add_graph onClick callback function binding which resulted in the graph option object getting referenced by multiple Prometheus.Graph

@TAYTS TAYTS force-pushed the fix/classic-ui-range-query branch from 8482565 to 5a45b5a Compare September 29, 2020 02:06
@roidelapluie
Copy link
Member

Thanks!!

cc @gouthamve (original reporter) @juliusv (UI)

@juliusv
Copy link
Member

juliusv commented Sep 30, 2020

👍 Thanks!

@juliusv juliusv merged commit c9d827c into prometheus:master Sep 30, 2020
@TAYTS TAYTS deleted the fix/classic-ui-range-query branch September 30, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classic UI sometimes runs queries for instant query when in range mode
3 participants