Include the name of the index in the error message when the generator can't handle an index #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add the DCO? |
|
Apparently to do this I need approval from someone who's now away until the new year, I'll come back to this in January. |
thomaswhiteway
force-pushed
the
improve-index-error
branch
from
fc08a8c to
b5e1ed0
Compare
can't handle an index Signed-off-by: Thomas Whiteway <[email protected]>
thomaswhiteway
force-pushed
the
improve-index-error
branch
from
b5e1ed0 to
fe29860
Compare
|
I now have approval for the DCO and have updated the commit. |
|
Thanks! |
brian-brazil
pushed a commit
that referenced
this pull request
Feb 5, 2019
…#369) can't handle an index Signed-off-by: Thomas Whiteway <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this to help debug an error I was hitting, I can confirm that it helps.