Fix inconsistent label cardinality error #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Nyurkin <[email protected]>
|
Thank you for finding this! #222 is functionally the same fix, and it also has a test to prevent regressions, so I hope you don't mind if I close this PR and go with that? |
|
Change of plan, since #222 is blocked on the DCO sign-off I'm going to merge this for now. |
matthiasr
pushed a commit
that referenced
this pull request
May 27, 2019
Signed-off-by: Matthias Rampke <[email protected]>
|
Sorry for introducing this. We don't use label mapping in our environment, so I missed this :( |
|
@claytono no problem, it's a minor thing, happens to everybody |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I've faced issue with latest statsd version:
Failed to update metric "asr_duration". Error: inconsistent label cardinality: expected 0 label values but got 4 in prometheus.LabelsIt happened after this commit d143398
Basically we sort prometheus labels (https://github.com/prometheus/statsd_exporter/blob/master/exporter.go#L461) before fill structure (https://github.com/prometheus/statsd_exporter/blob/master/exporter.go#L470)
Fixes issue for me, also rollback to v0.9.0 fixes it.