Move escapeMetricName to mapper #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakins
force-pushed
the
escape-to-mapper
branch
from
6418b11 to
1f0fb8b
Compare
matthiasr
approved these changes
Jan 16, 2020
| @@ -159,14 +104,14 @@ func (b *Exporter) handleEvent(event Event) { | |||
| errorEventStats.WithLabelValues("empty_metric_name").Inc() | |||
| return | |||
| } | |||
| metricName = escapeMetricName(mapping.Name) | |||
There was a problem hiding this comment.
is there anything that prevents us from making the mapper return an escaped name in the first place?
|
the new files are lacking the license header, could you add it please? |
Signed-off-by: bakins <[email protected]>
bakins
force-pushed
the
escape-to-mapper
branch
from
1f0fb8b to
e60f77d
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#234 (comment)
I've copy pasted this into multiple personal projects as well, so let's export this.
We could integrate it more into mapping later.